Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: mempool: chain errors using xerrors.Errorf #10836

Merged
merged 1 commit into from
May 5, 2023

Conversation

snissn
Copy link
Contributor

@snissn snissn commented May 5, 2023

Related Issues

https://github.com/filecoin-project/lotus/pull/10818/files

Proposed Changes

refactor log.Warnf to returning xerrors.Errorf

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@snissn snissn requested a review from a team as a code owner May 5, 2023 09:51
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@arajasek arajasek merged commit 49e1910 into master May 5, 2023
@arajasek arajasek deleted the mikers/messagepool/nitfix2 branch May 5, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants